WPIntell

Source evidence

WP Menu Icons crashes Jetpack plugin

WP Menu Icons · support · 2024-10-30T08:35:00+00:00

complaintsentiment
highseverity
1.0relevance
2replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

7 / 29 rows with source links

24.1% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

22 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
Manzoor Wani unresolved
Hello fellow developers 👋 I am one of the developers of Jetpack family of plugins at Automattic, reaching out to you regarding an issue caused by WP Menu Icons. We see that WP Menu Icons uses automattic/jetpack-assets package. Thank you for using it 😊. We develop/maintain that package in our Jetpack monorepo . We recently added some new JS functions to that package via its JS bundle. Yesterday, we had reports of at least one site using the WP Menu Icons plugin along with the Jetpack plugin ( v14.0-a.11 ) and the editor showed an error and the Jetpack settings page crashed. Steps to reproduce: Install the latest version of WP Menu Icons ( v3.2.7 ) Install the latest alpha of Jetpack – v14.0-a.11 Goto /wp-admin/admin.php?page=jetpack#/settings See the page crashed and check the browser console for the error – TypeError: (0 , s.siteHasFeature) is not a function The reason for the crash/error was that WP Menu Icons uses the automattic/jetpack-assets package via composer autoloader. Each plugin’s autoloader generally gets pushed into the start of the autoloader list, and WP generally loads plugins in alphabetical order by slug. So “wp-menu-icons” loads later than “jetpack” or “jetpack-social”, meaning its Composer autoloader winds up in the list before Jetpack Autoloader. Thus even if Jetpack has the updated version of the automattic/jetpack-assets package, the version with WP Menu Icons gets loaded, which does not contain the functions included in the version that Jetpack plugin bundles/uses. However, the recommended way of using automattic/jetpack-assets package in a WordPress plugin is mentioned in its documentation : Using this package in your WordPress plugin If you plan on using this package in your WordPress plugin, we would recommend that you use Jetpack Autoloader as your autoloader. This will allow for maximum interoperability with other plugins that use this package as well. So, we request you to use the recommended way of loading Jetpack packages to avoid such issues in future. Feel free to open an issue in the monorepo if you need any help or have questions. As a quick fix, you may update automattic/jetpack-assets to the latest version and do a patch release of the plugin. You may then continue working on that recommended solution mentioned above. Any update on this? We had to ask many site users to deactivate your plugins because of this issue.

Comments

2 shown
Manzoor Wani 2024-10-30T11:22:00+00:00

As a quick fix, you may update automattic/jetpack-assets to the latest version and do a patch release of the plugin. You may then continue working on that recommended solution mentioned above.

Manzoor Wani 2024-11-28T15:21:00+00:00

Any update on this? We had to ask many site users to deactivate your plugins because of this issue.