Conversation
supportwhy do you use your own translations for days of the week when they are already available for wordpress in all languages. Please don’t reinvent the wheel. Currently day of the week are only displayed in english as the other languages didn’t have the translations yet. Same goes for the date/time setting in the plugin, please use the same as in the general settings of wordpress , nothing more anoying then the need to configure the same setting in different places. If i find the time i will try to overule it in my own plugin ( https://wordpress.org/plugins/business-profile-extra-fields/ ) untill you can fix these issues.
found the issue : template-functions.php line 1011 the bpfwp_get_weekday_label function gets the names from the paid version of the plugin only fields without checking if they are empty or not and or use the default wordpress week language or your own default label for the weekday. Because your code is missing if ( ! function_exists bpfwp_get_weekday_label setting the values can’t be overruled as it will give a redeclare error.
changing that function to the following solves the problem function bpfwp_get_weekday_label( $weekday ) { //global $bpfwp_controller; //return $bpfwp_controller->settings->get_setting( ‘label-‘ . strtolower( $weekday ) ); return __( $weekday, ‘default’ ); }
Thank you for the comments and your suggestion. There are default values set for the weekday names, all of which are localized, so can be translated with any translation plugin that works with localized strings. I appreciate the suggestion to use the WordPress defaults. I’ll ask why it’s currently as it is, and, if we can make any updates to make that easier, we’ll definitely do so. Thanks again!
found the issue : template-functions.php line 1011 the bpfwp_get_weekday_label function gets the names from the paid version of the plugin only fields without checking if they are empty or not and or use the default wordpress week language or your own default label for the weekday. Because your code is missing if ( ! function_exists bpfwp_get_weekday_label setting the values can’t be overruled as it will give a redeclare error.
changing that function to the following solves the problem function bpfwp_get_weekday_label( $weekday ) { //global $bpfwp_controller; //return $bpfwp_controller->settings->get_setting( ‘label-‘ . strtolower( $weekday ) ); return __( $weekday, ‘default’ ); }
Thank you for the comments and your suggestion. There are default values set for the weekday names, all of which are localized, so can be translated with any translation plugin that works with localized strings. I appreciate the suggestion to use the WordPress defaults. I’ll ask why it’s currently as it is, and, if we can make any updates to make that easier, we’ll definitely do so. Thanks again!