Some I18N Issues

This plugin is awesome, but all localizable strings have the wrong text domain. The following are the modifications. admin\class-cf-christmasification-admin.php, line 60 to 61 add_menu_page( __('Christmasify', 'christmasify'), __('Christmasify!', 'christmasify'), 'manage_options', 'cf-christmasification-admin', array($this, 'options'), 'data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iaXNvLTg4NTktMSI/PjwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcgMS4xLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL0dyYXBoaWNzL1NWRy8xLjEvRFREL3N2ZzExLmR0ZCI+PHN2ZyB2ZXJzaW9uPSIxLjEiIGlkPSJDYXBhXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4IiB3aWR0aD0iMzcuNzgzcHgiIGhlaWdodD0iMzcuNzgzcHgiIHZpZXdCb3g9IjAgMCAzNy43ODMgMzcuNzgzIiBzdHlsZT0iZW5hYmxlLWJhY2tncm91bmQ6bmV3IDAgMCAzNy43ODMgMzcuNzgzOyIgeG1sOnNwYWNlPSJwcmVzZXJ2ZSI+PGc+PHBhdGggZD0iTTM0Ljk3MiwyNy4yODFsLTIuNzg5LTEuNjA5bDEuNTI1LTAuODgzYzAuMzczLTAuMjE2LDAuNTAxLTAuNjkzLDAuMjg1LTEuMDY2Yy0wLjIxNy0wLjM3My0wLjY5NC0wLjQ5OS0xLjA2Ny0wLjI4M2wtMi4zMDUsMS4zM2wtMS44OTYtMS4wOTZsNC41MzYtMi42MThjMC4zNzItMC4yMTYsMC41LTAuNjkxLDAuMjg1LTEuMDY2Yy0wLjIxNy0wLjM3MS0wLjY5NS0wLjUwMS0xLjA2Ni0wLjI4M2wtNS4zMTgsMy4wNjdsLTEuMjM4LTAuNzE3YzAuNDM1LTAuOTY0LDAuNjg0LTIuMDMyLDAuNjg0LTMuMTU3YzAtMS4xMjgtMC4yNDktMi4xOTQtMC42ODUtMy4xNjFsMS4yMzgtMC43MTZsNS4zMTgsMy4wN2MwLjEyMywwLjA3MSwwLjI1NywwLjEwNiwwLjM5MSwwLjEwNmMwLjI3MSwwLDAuNTMzLTAuMTQxLDAuNjc3LTAuMzkxYzAuMjE1LTAuMzczLDAuMDg3LTAuODUxLTAuMjg1LTEuMDY2bC00LjUzOC0yLjYyMmwxLjg5OC0xLjA5NWwyLjMwNywxLjMzM2MwLjEyMywwLjA3MSwwLjI1OCwwLjEwNiwwLjM5MSwwLjEwNmMwLjI3LDAsMC41MzItMC4xNDEsMC42NzctMC4zOTFjMC4yMTYtMC4zNzMsMC4wODgtMC44NTItMC4yODUtMS4wNjdsLTEuNTI2LTAuODgybDIuNzg4LTEuNjExYzAuMzczLTAuMjE2LDAuNTAxLTAuNjk0LDAuMjg1LTEuMDY2Yy0wLjIxNi0wLjM3Mi0wLjY5NS0wLjUtMS4wNjYtMC4yODRsLTIuNzg3LDEuNjF2LTEuNzZjMC0wLjQzMS0wLjM1MS0wLjc4MS0wLjc4MS0wLjc4MWMtMC40MzIsMC0wLjc4MSwwLjM1LTAuNzgxLDAuNzgxbDAuMDAxLDIuNjYzbC0xLjg5NiwxLjA5NWwwLjAwMS01LjIzNWMwLTAuNDMyLTAuMzQ5LTAuNzgxLTAuNzgxLTAuNzgxYy0wLjQzMSwwLTAuNzgxLDAuMzUtMC43ODEsMC43ODFsLTAuMDAxLDYuMTM5TDI1LjE0LDE0LjM5Yy0xLjI1OS0xLjczOS0zLjIxOS0yLjkzOS01LjQ2Ny0zLjE2N1Y5Ljc5N2w1LjMxNi0zLjA3YzAuMzczLTAuMjE1LDAuNTAxLTAuNjkzLDAuMjg1LTEuMDY2Yy0wLjIxNi0wLjM3NC0wLjY5NC0wLjUwMS0xLjA2Ni0wLjI4NWwtNC41MzUsMi42MjFWNS44MDhsMi4zMDYtMS4zMzFjMC4zNzQtMC4yMTYsMC41LTAuNjk0LDAuMjg1LTEuMDY2Yy0wLjIxNy0wLjM3Mi0wLjY5NS0wLjUwMi0xLjA2Ni0wLjI4NWwtMS41MjUsMC44NzlWMC43ODFDMTkuNjcyLDAuMzUsMTkuMzIyLDAsMTguODkxLDBTMTguMTEsMC4zNSwxOC4xMSwwLjc4MXYzLjIyMWwtMS41MjQtMC44ODFjLTAuMzc0LTAuMjE2LTAuODUxLTAuMDg4LTEuMDY3LDAuMjg0Yy0wLjIxNiwwLjM3Mi0wLjA4OCwwLjg1LDAuMjg1LDEuMDY2bDIuMzA2LDEuMzMzdjIuMTg4bC00LjUzNi0yLjYxOWMtMC4zNzItMC4yMTUtMC44NTEtMC4wODgtMS4wNjYsMC4yODZjLTAuMjE2LDAuMzczLTAuMDg3LDAuODUxLDAuMjg1LDEuMDY2bDUuMzE3LDMuMDY5djEuNDI3Yy0yLjI0OCwwLjIyNy00LjIwOCwxLjQyOC01LjQ2NywzLjE2N2wtMS4yNDYtMC43MThWNy41MjljMC0wLjQzMS0wLjM1LTAuNzgxLTAuNzgxLTAuNzgxcy0wLjc4MSwwLjM1LTAuNzgxLDAuNzgxdjUuMjM3bC0xLjg5NC0xLjA5NUw3Ljk0LDkuMDA2YzAtMC40MzEtMC4zNS0wLjc4MS0wLjc4MS0wLjc4MXMtMC43ODEsMC4zNS0wLjc4MSwwLjc4MXYxLjc2TDMuNTg5LDkuMTU4QzMuMjE2LDguOTQyLDIuNzM4LDkuMDcsMi41MjIsOS40NDJzLTAuMDg3LDAuODUxLDAuMjg1LDEuMDY1bDIuNzg5LDEuNjEybC0xLjUyNSwwLjg4Yy0wLjM3NCwwLjIxNi0wLjUwMSwwLjY5NC0wLjI4NiwxLjA2N2MwLjE0NSwwLjI1LDAuNDA4LDAuMzkxLDAuNjc3LDAuMzkxYzAuMTMyLDAsMC4yNjctMC4wMzMsMC4zOTEtMC4xMDZsMi4zMDUtMS4zM2wxLjg5NiwxLjA5NWwtNC41MzcsMi42MTljLTAuMzc0LDAuMjE2LTAuNTAxLDAuNjk0LTAuMjg1LDEuMDY3YzAuMTQ1LDAuMjUsMC40MDcsMC4zOTEsMC42NzcsMC4zOTFjMC4xMzIsMCwwLjI2Ni0wLjAzNCwwLjM5MS0wLjEwNmw1LjMxNi0zLjA3bDEuMjQzLDAuNzE3Yy0wLjQzNiwwLjk2Ni0wLjY4MywyLjAzNC0wLjY4MywzLjE2YzAsMS4xMjgsMC4yNDgsMi4xOSwwLjY4MywzLjE1N2wtMS4yNDEsMC43MTdsLTUuMzItMy4wNjVjLTAuMzczLTAuMjE2LTAuODUxLTAuMDg4LTEuMDY2LDAuMjg0Yy0wLjIxNiwwLjM3NC0wLjA4NiwwLjg1MiwwLjI4NywxLjA2N2w0LjUzNiwyLjYxN2wtMS44OTcsMS4wOTdsLTIuMzA0LTEuMzMzYy0wLjM3My0wLjIxMy0wLjg1MS0wLjA4Ny0xLjA2NywwLjI4NWMtMC4yMTYsMC4zNzMtMC4wODgsMC44NTIsMC4yODUsMS4wNjdsMS41MjUsMC44ODJMMi44MSwyNy4yNzdjLTAuMzc0LDAuMjE2LTAuNTAxLDAuNjkzLTAuMjg1LDEuMDY1YzAuMTQ1LDAuMjUsMC40MDcsMC4zOTEsMC42NzcsMC4zOTFjMC4xMzIsMCwwLjI2Ni0wLjAzMiwwLjM5MS0wLjEwN2wyLjc4OS0xLjYwOWwwLjAwMSwxLjc2MmMwLDAuNDMyLDAuMzUsMC43ODEsMC43ODEsMC43ODFsMCwwYzAuNDMxLDAsMC43ODEtMC4zNSwwLjc4MS0wLjc4MWwtMC4wMDItMi42NjVsMS44OTgtMS4wOTVsLTAuMDAxLDUuMjM5YzAsMC40MzEsMC4zNDksMC admin\partials\cf-christmasification-admin-display.php Line 16 <h1><?php esc_html_e('Christmasify! Settings', 'christmasify'); ?></h1> Line 22 <th scope="row"><?php esc_html_e('I want Snowflakes!', 'christmasify'); ?></th> Line 23 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Snowflakes', 'christmasify'); ?></span></legend><label for="snowflakes"> Line 28 <th scope="row"><label for="music"><?php esc_html_e('My visitors would love this jingle:', 'christmasify'); ?></label></th> Line 38 <th scope="row"><?php esc_html_e('Flying Santa would be awesome!', 'christmasify'); ?></th> Line 39 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Flying Santa would be awesome!', 'christmasify'); ?></span></legend><label for="santa"> Line 44 <th scope="row"><?php esc_html_e('Christmas decorations for images?', 'christmasify'); ?></th> Line 45 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Christmasy decorations for images? Okay!', 'christmasify'); ?></span></legend><label for="image_frame"> Line 50 <th scope="row"><?php esc_html_e('Christmassy headings?', 'christmasify'); ?></th> Line 51 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Christmassy headings?', 'christmasify'); ?></span></legend><label for="font"> Line 56 <th scope="row"><?php esc_html_e('Homepage Only?', 'christmasify'); ?></th> Line 57 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Only show Christmas effects on the homepage', 'christmasify'); ?></span></legend><label for="homepage_only"> Line 63 <p class="submit"><input type="submit" name="submit" id="submit" class="button button-primary" value="<?php echo esc_attr_x( 'Christmasify!', 'Button Label', 'christmasify' ); ?>"></p> Line 66 <p><?php esc_html_e( 'If you like this plugin please give us a like or share this plugin on Facebook :)', 'christmasify' ); ?></p> Line 70 <p><?php _e( 'If you like this plugin please give us a like or share this plugin on Facebook, or give us a nice rating on <a href="https://wordpress.org/plugins/christmasify/">WordPress</a> :)', 'christmasify' ); ?></p> If this plugin has its own public GitHub repository, please let me know, then I will submit PR for this plugin. This topic was modified 3 years, 6 months ago by Alex Lion (阿力獅) . If this plugin has its public GitHub repository, please let me know, then I will submit PR for this plugin. There is no change of I18N in the current 1.3.0, so I make the necessary modifications for 1.3.0 as follows. The following modifications let localized UI strings display correctly. admin\class-cf-christmasification-admin.php, line 60 add_menu_page( __('Christmasify', 'christmasify'), __('Christmasify!', 'christmasify'), 'manage_options', 'cf-christmasification-admin', array($this, 'options'), \admin\partials\cf-christmasification-admin-display.php Line 16 <h1><?php esc_html_e(‘Christmasify! Settings’, ‘christmasify’); ?></h1> Line 22 <th scope="row"><?php esc_html_e('I want Snowflakes!', 'christmasify'); ?></th> Line 23 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Snowflakes', 'christmasify'); ?></span></legend><label for="snowflakes"> Line 25 to 31 <option value="0" <?php selected(get_option('cf_christmasify_snowflakes'), 0) ?> ><?php esc_html_e('None', 'christmasify'); ?></option> <option value="10" <?php selected(get_option('cf_christmasify_snowflakes'), 10) ?> ><?php esc_html_e('Light', 'christmasify'); ?></option> <option value="25" <?php selected(get_option('cf_christmasify_snowflakes'), 25) ?> ><?php esc_html_e('Medium', 'christmasify'); ?></option> <option value="50" <?php selected(get_option('cf_christmasify_snowflakes'), 50) ?> ><?php esc_html_e('Heavy', 'christmasify'); ?></option> <option value="100" <?php selected(get_option('cf_christmasify_snowflakes'), 100) ?> ><?php esc_html_e('Snowstorm', 'christmasify'); ?></option> <option value="200" <?php selected(get_option('cf_christmasify_snowflakes'), 200) ?> ><?php esc_html_e('Insanity', 'christmasify'); ?></option> <option value="400" <?php selected(get_option('cf_christmasify_snowflakes'), 400) ?> ><?php esc_html_e('Beyond Insanity', 'christmasify'); ?></option> Line 37 <th scope="row"><label for="music"><?php esc_html_e('My visitors would love this jingle:', 'christmasify'); ?></label></th> Line 47 <th scope="row"><?php esc_html_e('Flying Santa would be awesome!', 'christmasify'); ?></th> Line 48 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Flying Santa would be awesome!', 'christmasify'); ?></span></legend><label for="santa"> Line 53 <th scope="row"><?php esc_html_e('Christmas decorations for images?', 'christmasify'); ?></th> Line 54 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Christmasy decorations for images? Okay!', 'christmasify'); ?></span></legend><label for="image_frame"> Line 59 <th scope="row"><?php esc_html_e('Christmassy headings?', 'christmasify'); ?></th> Line 60 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Christmassy headings?', 'christmasify'); ?></span></legend><label for="font"> Line 65 <th scope="row"><?php esc_html_e('Homepage Only?', 'christmasify'); ?></th> Line 66 <td> <fieldset><legend class="screen-reader-text"><span><?php esc_html_e('Only show Christmas effects on the homepage', 'christmasify'); ?></span></legend><label for="homepage_only"> Line 72 <p class="submit"><input type="submit" name="submit" id="submit" class="button button-primary" value="<?php echo esc_attr_x( 'Christmasify!', 'Button Label', 'christmasify' ); ?>"></p> Line 75 <p><?php esc_html_e( 'If you like this plugin please give us a like or share this plugin on Facebook :)', 'christmasify' ); ?></p> Line 79 <p><?php _e( 'If you like this plugin please give us a like or share this plugin on Facebook, or give us a nice rating on <a href="https://wordpress.org/plugins/christmasify/">WordPress</a> :)', 'christmasify' ); ?></p> Please let this awesome plugin shows its localized UI string correctly. Thanks. \admin\partials\cf-christmasification-admin-display.php, Line 40 <option value="" <?php selected(get_option('cf_christmasify_music') , 0); ?>><?php esc_html_e('No Music', 'christmasify'); ?></option> @cyberfoxdigital Localized UI is very useful for non-English users, and displaying localized UI strings correctly is important for community translators. zh_TW UI strings are fully localized but this plugin can’t display localized UI strings, it’s a pity! This reply was modified 3 years, 5 months ago by Alex Lion (阿力獅) . This reply was modified 3 years, 5 months ago by Alex Lion (阿力獅) . Hi Alex, Honestly this is great, thank you! I’ll update the plugin shortly with your changes, let me know if there’s anything else! Thanks, Adam Thanks for updating this great plugin. I uploaded new translations for the updated GlotPress project, now it can display localized UI strings correctly for ALL languages, including zh_TW (Taiwan). I also wrote a simple Facebook post to introduce this plugin to Taiwan users. Hope all of them enjoy this.