WPIntell

Source evidence

So many problems and unsecure code

Mail Subscribe List · support · 2016-12-27T10:59:00+00:00

complaintsentiment
highseverity
0.96relevance
2replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

5 / 34 rows with source links

14.7% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

29 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
wooody unresolved
Hi I think you need to review the plugin code again and stop direct access for files: /wp-content/plugins/mail-subscribe-list/index.php /wp-content/plugins/mail-subscribe-list/sml.php Regards Please add nonce to your form. My list got flooded with spam. I have made the following changes. on line 71 $return = '<form class="sml_subscribe" method="post" id="sml_subscribe" action="/#sml_subscribe"><input class="sml_hiddenfield" name="sml_subscribe" type="hidden" value="1">'.wp_nonce_field( 'creating_email_subscription', 'email_subscription' ); on line 273 // Handle form Post add_action('init', 'sml_post_action'); function sml_post_action(){ global $wpdb; if ($_POST['sml_subscribe'] &&(isset( $_POST['email_subscription'] ) && wp_verify_nonce( $_POST['email_subscription'], 'creating_email_subscription' ) )) { $name = $_POST['sml_name']; $email = $_POST['sml_email']; if (is_email($email)) { $exists = mysql_query("SELECT * FROM ".$wpdb->prefix."sml where sml_email like '".$wpdb->escape($email)."' limit 1"); if (mysql_num_rows($exists) <1) { $wpdb->query("insert into ".$wpdb->prefix."sml (sml_name, sml_email) values ('".$wpdb->escape($name)."', '".$wpdb->escape($email)."')"); } } } } Hi SandyRig, Thanks for the fixing and please if you can update the plugin code and make it as updates.

Comments

2 shown
SandyRig 2017-01-12T14:30:00+00:00

Please add nonce to your form. My list got flooded with spam. I have made the following changes. on line 71 $return = '<form class="sml_subscribe" method="post" id="sml_subscribe" action="/#sml_subscribe"><input class="sml_hiddenfield" name="sml_subscribe" type="hidden" value="1">'.wp_nonce_field( 'creating_email_subscription', 'email_subscription' ); on line 273 // Handle form Post add_action('init', 'sml_post_action'); function sml_post_action(){ global $wpdb; if ($_POST['sml_subscribe'] &&(isset( $_POST['email_subscription'] ) && wp_verify_nonce( $_POST['email_subscription'], 'creating_email_subscription' ) )) { $name = $_POST['sml_name']; $email = $_POST['sml_email']; if (is_email($email)) { $exists = mysql_query("SELECT * FROM ".$wpdb->prefix."sml where sml_email like '".$wpdb->escape($email)."' limit 1"); if (mysql_num_rows($exists) <1) { $wpdb->query("insert into ".$wpdb->prefix."sml (sml_name, sml_email) values ('".$wpdb->escape($name)."', '".$wpdb->escape($email)."')"); } } } }

wooody 2017-01-23T13:08:00+00:00

Hi SandyRig, Thanks for the fixing and please if you can update the plugin code and make it as updates.