WPIntell

Source evidence

Please remove extra empty in fieldset

Gravity Fieldset for Gravity Forms · support · 2016-07-25T19:06:00+00:00

questionsentiment
highseverity
0.76relevance
2replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

5 / 25 rows with source links

20.0% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

20 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
mkormendy resolved
There’s an extra empty <li></i> being created immediately at the beginning of the fieldset. If there’s padding, margin or dimensions styling on the sibling <li> ‘s in that set, then the first <li></li> creates a blank gap. Of course I could just use li:first-child {display: none;} however it’s adding even more code on top of the extra unused tag – not very optimal at all. I modified the plugin code and removed the <li> </li> components on lines 281 and 286. This seems to have fixed it, but without analyzing the entire plugin code, I won’t know if they’re needed elsewhere (which in my test-case, hasn’t affected my layouts). https://wordpress.org/plugins/gravity-fieldset-for-gravity-forms/ Hi mkormendy, Thanks for your feedback. We will look into this for our next release. We are now ‘hacking’ the structure of GF in order to make fieldsets possible but we are looking into GF itself in order to make it more native and output proper HTML. We will take a look at the spare list item as well. Cheers, Harro Hi Mkormendy, We just updated the plugin and the HTML output is much neater then before. Therefore we also removed the empty li’s and ul’s. Hope you like the new output. Cheers, Harro

Comments

2 shown
HarroH 2016-08-01T13:16:00+00:00

Hi mkormendy, Thanks for your feedback. We will look into this for our next release. We are now ‘hacking’ the structure of GF in order to make fieldsets possible but we are looking into GF itself in order to make it more native and output proper HTML. We will take a look at the spare list item as well. Cheers, Harro

HarroH 2016-12-08T10:13:00+00:00

Hi Mkormendy, We just updated the plugin and the HTML output is much neater then before. Therefore we also removed the empty li’s and ul’s. Hope you like the new output. Cheers, Harro