Conversation
supportGetting these in a clients debug.log file: [23-Oct-2023 06:00:16 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 109 in .../wp-includes/class-simplepie.php on line 1599 The URL https://themeisle.com/blog/feed which is defined in vendor/codeinwp/themeisle-sdk/src/Modules/Dashboard_widget.php sometimes does not return XML but HTML as response so the code in setup_feeds() fails in dashboard widget without proper error handling. Menu Icons 0.13.7, WordPress 6.3.2, PHP 8.1.x This problem affects also other plugins which use themeisle-sdk .
The returned HTML is a typical WP 404 not found page, here the shortened source: <!DOCTYPE html> <html class="optml_no_js" lang="en-US"> <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1"> <link rel="profile" href="http://gmpg.org/xfn/11"> <meta name='robots' content='noindex, follow' /> <!-- __ __ _ _ _ \ \ / /__ __ _ _ __ ___ | |__ (_)_ __(_)_ __ __ _ \ \ /\ / / _ \ / _ | '__/ _ \ | '_ \| | '__| | '_ \ / _ | \ V V / __/ | (_| | | | __/ | | | | | | | | | | | (_| | \_/\_/ \___| \__,_|_| \___| |_| |_|_|_| |_|_| |_|\__, | |___/ Ever thought about joining us? [----snip----] ---> <!-- This site is optimized with the Yoast SEO plugin v20.11 - https://yoast.com/wordpress/plugins/seo/ --> <title>Page not found - Themeisle</title> <meta property="og:locale" content="en_US" /> <meta property="og:title" content="Page not found - Themeisle" /> <meta property="og:site_name" content="Themeisle" /> <script type="application/ld+json" class="yoast-schema-graph">{"@context":"https://schema.org","@graph":[{"@type":"WebSite","@id":"https://themeisle.com/#website","url":"https://themeisle.com/","name":"Themeisle","description":"","publisher":{"@id":"https://theme[----snip----]e"]}]}</script> <!-- / Yoast SEO plugin. --> <link rel='dns-prefetch' href='//use.typekit.net' /> <link rel='dns-prefetch' href='//mllj2j8xvfl0.i.optimole.com' /> <link rel='preconnect' href='https://mllj2j8xvfl0.i.optimole.com' /> <link rel="alternate" type="application/rss+xml" title="Themeisle » Feed" href="https://themeisle.com/feed/?utm_source=themeisle&utm_medium=product&utm_campaign=blogfeed" /> <link rel="alternate" type="application/rss+xml" title="Themeisle » Comments Feed" href="https://themeisle.com/comments/feed/?utm_source=themeisle&utm_medium=product&utm_campaign=blogfeed" /> <link rel='stylesheet' id='wp-block-library-css' href='https://themeisle.com/wp-includes/css/dist/block-library/style.min.css?ver=6.2.3' type='text/css' media='all' /> <link rel='stylesheet' id='classic-theme-styles-css' href='https://themeisle.com/wp-includes/css/classic-themes.min.css?ver=6.2.3' type='text/css' media='all' /> <style id='global-styles-inline-css' type='text/css'> body{--wp--preset--color--black: #000000;--wp--preset--color--cyan-blu [----snip----] </head> <body class="error404 wp-custom-logo nv-blog-grid nv-sidebar-full-width menu_sidebar_slide_left" > [----snip----]
Hello @ov3rfly , Thank you for using our products and for reporting the issue encountered! The mentioned warning should not appear anymore as the URL mentioned is working as expected now. Sorry about the inconvenience created. Best regards, Irinel
The URL mentioned was working as expected before – most of the time. The URL sometimes does not return XML feed but HTML WP 404 page as response. Maybe you could add proper error handling to inform user in dashboard as already mentioned as TODO in your code in Dashboard_widget.php : // TODO report error when is an error loading the feed.
Hello, Thank you for the detailed research on this matter! I forwarded the issue to development. What happens next? Our product team will evaluate the impact of this issue compared to other open bugs and upcoming features, and assign a priority level to the bug report. Our developers prioritize the highest-priority issues first, so we cannot provide a specific timeline for resolution at this time. Best regards, Irinel This reply was modified 2 years, 7 months ago by irinelenache .
Same problem still happens also with updated themeisle-sdk 3.3.11. [10-Jan-2024 07:24:21 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 109 in .../wp-includes/class-simplepie.php on line 1599 Menu Icons 0.13.8, WordPress 6.4.2, PHP 8.1.x
Hello @ov3rfly , The issue was fixed with the latest release of the plugin, and I’m not able to replicate it anymore. There is probably a caching problem on your end and that’s why the notice is still visible. Have a great day ahead, Irinel
The issue is not fixed, as described I saw the issue again with latest release Menu Icons 0.13.8 with themeisle-sdk 3.3.11. You can replicate the issue if the XML URL sometimes does not return XML feed but HTML WP 404 page as response. No caching is involved in the issue.
Hey @ov3rfly , We apologize for the delay. Can you kindly confirm if the issue still persists?
The issue is not fixed, as described I saw the issue again with latest release Menu Icons 0.13.8 with themeisle-sdk 3.3.11. [31-Jan-2024 08:06:48 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 109 in .../wp-includes/class-simplepie.php on line 1599
Hey @ov3rfly , Can you please share some screenshots? I cannot seem to spot this issue anymore – https://vertis.d.pr/i/0crJKg .
You can replicate the issue if the XML URL sometimes does not return XML feed but HTML WP 404 page as response.
Hey @ov3rfly , I apologize for any inconvenience you experienced. The issue has already been forwarded to our products team for investigation, and a fix has already been included in the latest release. Neither I nor my teammate were able to replicate it anymore, so please feel free to open a new issue in case the same problem occurs again. Please ensure to add screenshots and provide detailed steps to replicate the issue. Have a great day, and thank you for using our products! Best regards, Andreea
Steps to replicate: Enable WP_DEBUG_LOG Wait until XML URL sometimes does not return XML feed but HTML WP 404 page Find error in debug.log [08-Feb-2024 07:44:49 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) ... And what fix are you talking about? a fix has already been included in the latest release There was no release since December 2023 and no fix is included there.
Same problem again today in debug.log file: [20-Feb-2024 05:55:32 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 110 ... Menu Icons 0.13.8, WordPress 6.4.3, PHP 8.1.x
The returned HTML is a typical WP 404 not found page, here the shortened source: <!DOCTYPE html> <html class="optml_no_js" lang="en-US"> <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1"> <link rel="profile" href="http://gmpg.org/xfn/11"> <meta name='robots' content='noindex, follow' /> <!-- __ __ _ _ _ \ \ / /__ __ _ _ __ ___ | |__ (_)_ __(_)_ __ __ _ \ \ /\ / / _ \ / _ | '__/ _ \ | '_ \| | '__| | '_ \ / _ | \ V V / __/ | (_| | | | __/ | | | | | | | | | | | (_| | \_/\_/ \___| \__,_|_| \___| |_| |_|_|_| |_|_| |_|\__, | |___/ Ever thought about joining us? [----snip----] ---> <!-- This site is optimized with the Yoast SEO plugin v20.11 - https://yoast.com/wordpress/plugins/seo/ --> <title>Page not found - Themeisle</title> <meta property="og:locale" content="en_US" /> <meta property="og:title" content="Page not found - Themeisle" /> <meta property="og:site_name" content="Themeisle" /> <script type="application/ld+json" class="yoast-schema-graph">{"@context":"https://schema.org","@graph":[{"@type":"WebSite","@id":"https://themeisle.com/#website","url":"https://themeisle.com/","name":"Themeisle","description":"","publisher":{"@id":"https://theme[----snip----]e"]}]}</script> <!-- / Yoast SEO plugin. --> <link rel='dns-prefetch' href='//use.typekit.net' /> <link rel='dns-prefetch' href='//mllj2j8xvfl0.i.optimole.com' /> <link rel='preconnect' href='https://mllj2j8xvfl0.i.optimole.com' /> <link rel="alternate" type="application/rss+xml" title="Themeisle » Feed" href="https://themeisle.com/feed/?utm_source=themeisle&utm_medium=product&utm_campaign=blogfeed" /> <link rel="alternate" type="application/rss+xml" title="Themeisle » Comments Feed" href="https://themeisle.com/comments/feed/?utm_source=themeisle&utm_medium=product&utm_campaign=blogfeed" /> <link rel='stylesheet' id='wp-block-library-css' href='https://themeisle.com/wp-includes/css/dist/block-library/style.min.css?ver=6.2.3' type='text/css' media='all' /> <link rel='stylesheet' id='classic-theme-styles-css' href='https://themeisle.com/wp-includes/css/classic-themes.min.css?ver=6.2.3' type='text/css' media='all' /> <style id='global-styles-inline-css' type='text/css'> body{--wp--preset--color--black: #000000;--wp--preset--color--cyan-blu [----snip----] </head> <body class="error404 wp-custom-logo nv-blog-grid nv-sidebar-full-width menu_sidebar_slide_left" > [----snip----]
Hello @ov3rfly , Thank you for using our products and for reporting the issue encountered! The mentioned warning should not appear anymore as the URL mentioned is working as expected now. Sorry about the inconvenience created. Best regards, Irinel
The URL mentioned was working as expected before – most of the time. The URL sometimes does not return XML feed but HTML WP 404 page as response. Maybe you could add proper error handling to inform user in dashboard as already mentioned as TODO in your code in Dashboard_widget.php : // TODO report error when is an error loading the feed.
Hello, Thank you for the detailed research on this matter! I forwarded the issue to development. What happens next? Our product team will evaluate the impact of this issue compared to other open bugs and upcoming features, and assign a priority level to the bug report. Our developers prioritize the highest-priority issues first, so we cannot provide a specific timeline for resolution at this time. Best regards, Irinel This reply was modified 2 years, 7 months ago by irinelenache .
Same problem still happens also with updated themeisle-sdk 3.3.11. [10-Jan-2024 07:24:21 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 109 in .../wp-includes/class-simplepie.php on line 1599 Menu Icons 0.13.8, WordPress 6.4.2, PHP 8.1.x
Hello @ov3rfly , The issue was fixed with the latest release of the plugin, and I’m not able to replicate it anymore. There is probably a caching problem on your end and that’s why the notice is still visible. Have a great day ahead, Irinel
The issue is not fixed, as described I saw the issue again with latest release Menu Icons 0.13.8 with themeisle-sdk 3.3.11. You can replicate the issue if the XML URL sometimes does not return XML feed but HTML WP 404 page as response. No caching is involved in the issue.
Hey @ov3rfly , We apologize for the delay. Can you kindly confirm if the issue still persists?
The issue is not fixed, as described I saw the issue again with latest release Menu Icons 0.13.8 with themeisle-sdk 3.3.11. [31-Jan-2024 08:06:48 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 109 in .../wp-includes/class-simplepie.php on line 1599
Hey @ov3rfly , Can you please share some screenshots? I cannot seem to spot this issue anymore – https://vertis.d.pr/i/0crJKg .
You can replicate the issue if the XML URL sometimes does not return XML feed but HTML WP 404 page as response.
Hey @ov3rfly , I apologize for any inconvenience you experienced. The issue has already been forwarded to our products team for investigation, and a fix has already been included in the latest release. Neither I nor my teammate were able to replicate it anymore, so please feel free to open a new issue in case the same problem occurs again. Please ensure to add screenshots and provide detailed steps to replicate the issue. Have a great day, and thank you for using our products! Best regards, Andreea
Steps to replicate: Enable WP_DEBUG_LOG Wait until XML URL sometimes does not return XML feed but HTML WP 404 page Find error in debug.log [08-Feb-2024 07:44:49 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) ... And what fix are you talking about? a fix has already been included in the latest release There was no release since December 2023 and no fix is included there.
Same problem again today in debug.log file: [20-Feb-2024 05:55:32 UTC] PHP Notice: https://themeisle.com/blog/feed is invalid XML, likely due to invalid characters. XML error: Comment must not contain '--' (double-hyphen) at line 20, column 110 ... Menu Icons 0.13.8, WordPress 6.4.3, PHP 8.1.x