Conversation
supportWhen I activate your plugin I get the following PHP warning: Notice: load_plugin_textdomain was called with an argument that is deprecated since version 2.7 with no alternative available http://wordpress.org/plugins/formilla-live-chat/
Hi there, What theme are you using when activating the plugin? Haven’t seen this particular warning but would like to try mimicking your setup. I also see you’re on 3.7.1 for wp, correct? The plugin itself doesn’t call this method so I’m curious what it could be with some research. Aside from the warning, is everything working from what you can tell in regards to the plugin (i.e. no side effects)? Thanks for bringing this to our attention!
Hi, It’s a completely custom theme on 3.7.1. We’re not using any translations. I can reliably get the error to appear/disappear by adding/removing your plugin. Looking at your code I see this on line 13: load_plugin_textdomain($formilla_domain, 'wp-content/plugins/formilla-live-chat'); Lots of other plugins I have installed are calling it with 3 parameters like the codex page load_plugin_textdomain( 'my-plugin', false, dirname( plugin_basename( __FILE__ ) ) ); I can get to the settings page fine – my client hasn’t actually given me account details to test with, so I’m not sure if the rest of the plugin works. Cheers, Adam
Adam, Good looking out! I totally overlooked it in the code. You’re right, without false for the 2nd parameter, a 2 param call is being considered depra. Looks like all works well regardless of the warning, although I’ll just knock this out in the next plugin update to clean it up. Thanks for your help – one thing I’m not seeing myself is the warning. When I activate in my testing, all looks clean. Are you seeing it on the wp activate plugin screen after installing the plugin? And if so, are you in a debug/verbose type of mode? Hope you enjoy the plugin, much appreciate your research. Zack
Hi Zack, Awesome, glad I could help! We have E_ALL on in dev mode to catch little things like this. It was appearing on every admin page that I looked at, not sure but it was probably on the front end as well. Because it wrote the warning to the browser, it breaks anything that needs to do a redirect as output has already been written. Any idea when you’ll be putting out an updated version? Cheers, Adam
Hi Adam, I’m with you now. Don’t have a solid date yet on the next build although it won’t be too down the road. I did make the change locally and some preliminary testing looks fine. I can send you a zip of the latest if you want, or the line I changed exactly if you want something sooner. Let me know – just email me at help@formilla.com and I can shoot it over. Zack Formilla.com
Hello, This is officially corrected and released via 1.0.2! Zack Formilla.com
Hi there, What theme are you using when activating the plugin? Haven’t seen this particular warning but would like to try mimicking your setup. I also see you’re on 3.7.1 for wp, correct? The plugin itself doesn’t call this method so I’m curious what it could be with some research. Aside from the warning, is everything working from what you can tell in regards to the plugin (i.e. no side effects)? Thanks for bringing this to our attention!
Hi, It’s a completely custom theme on 3.7.1. We’re not using any translations. I can reliably get the error to appear/disappear by adding/removing your plugin. Looking at your code I see this on line 13: load_plugin_textdomain($formilla_domain, 'wp-content/plugins/formilla-live-chat'); Lots of other plugins I have installed are calling it with 3 parameters like the codex page load_plugin_textdomain( 'my-plugin', false, dirname( plugin_basename( __FILE__ ) ) ); I can get to the settings page fine – my client hasn’t actually given me account details to test with, so I’m not sure if the rest of the plugin works. Cheers, Adam
Adam, Good looking out! I totally overlooked it in the code. You’re right, without false for the 2nd parameter, a 2 param call is being considered depra. Looks like all works well regardless of the warning, although I’ll just knock this out in the next plugin update to clean it up. Thanks for your help – one thing I’m not seeing myself is the warning. When I activate in my testing, all looks clean. Are you seeing it on the wp activate plugin screen after installing the plugin? And if so, are you in a debug/verbose type of mode? Hope you enjoy the plugin, much appreciate your research. Zack
Hi Zack, Awesome, glad I could help! We have E_ALL on in dev mode to catch little things like this. It was appearing on every admin page that I looked at, not sure but it was probably on the front end as well. Because it wrote the warning to the browser, it breaks anything that needs to do a redirect as output has already been written. Any idea when you’ll be putting out an updated version? Cheers, Adam
Hi Adam, I’m with you now. Don’t have a solid date yet on the next build although it won’t be too down the road. I did make the change locally and some preliminary testing looks fine. I can send you a zip of the latest if you want, or the line I changed exactly if you want something sooner. Let me know – just email me at help@formilla.com and I can shoot it over. Zack Formilla.com
Hello, This is officially corrected and released via 1.0.2! Zack Formilla.com