WPIntell

Source evidence

Javascript error if options set to false

ConverseJS · support · 2014-09-17T23:23:00+00:00

ConverseJS plugin evidence original source source API
mixedsentiment
mediumseverity
0.85relevance
2replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

6 / 26 rows with source links

23.1% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

20 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
gbonvehi resolved
Hi there, Thanks for making this plugin, it helped to quickly setup and test our xmpp server on our webpages. Just a small bug I found while testing In conversejs.php you’ve the following lines: $call = (get_option('call')) ?: false; $carbons = (get_option('carbons')) ?: false; $foward = (get_option('foward')) ?: false; which should be: $call = (get_option('call')) ?: 'false'; $carbons = (get_option('carbons')) ?: 'false'; $foward = (get_option('foward')) ?: 'false'; as false casted to string yields an empty string, thus the javascript generated below contains errors. Cheers, Guillermo https://wordpress.org/plugins/conversejs/ fixed in 1.5.6 version thank you and sorry

Comments

2 shown
Preexist Kudos 2014-10-13T13:24:00+00:00

fixed in 1.5.6 version

Preexist Kudos 2014-10-13T13:24:00+00:00

thank you and sorry