WPIntell

Source evidence

Issue with redis object caching

Simple Revisions Delete · support · 2020-09-16T03:19:00+00:00

mixedsentiment
highseverity
0.95relevance
12replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

5 / 35 rows with source links

14.3% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

30 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
Greys resolved
Hi, I am currently using the plugin with WooCommerce and Redis Object Cache by Till Krüss on a few sites. However, I encountered a somewhat annoying issue. Once the Simple Revisions Delete plugin is activated with these plugins, the price of variable products does not correspond to the one entered. Once deactivated, the problem no longer exists. It is important to note that this problem does not occur for simple products, only variable products. Is there a specific reason for this happening? And if so, would it be possible to remedy it? Hi, I can’t see any reason why this issue happens. The plugin is mostly using core functions and do not interact on the caching side. Can you tell me if you’re using the classic editor or no ? If you have any javascript error in the console ? If there is XHR issues ? Cheers, Brice Hi @brikou , Totally agree, when I was troubleshooting this issue, I did not think your plugin could be the cause. You can reproduce the exact same issue with a fresh install with WooCommerce and Redis Object Cache installed and activated. Nothing more. The theme used doesn’t matter. On the other hand, I do not have any javascript or PHP errors. Cheers, John Greys This reply was modified 5 years, 8 months ago by Greys . This reply was modified 5 years, 8 months ago by Greys . Hmmm… I thinks I was wrong ! I totally forgot that I did a fix for W3 Total Cache a few years ago because of object caching issues… Fortunatly you can disable the related filters with the following hooks. remove_action( 'set_transient_wpsrd_settings_errors', 'wpsrd_enable_linked_in_cached' ); remove_action( 'transient_wpsrd_settings_errors', 'wpsrd_enable_linked_in_cached' ); remove_action( 'deleted_transient_wpsrd_settings_errors', 'wpsrd_enable_linked_in_cached' ); remove_action( 'pre_set_transient_wpsrd_settings_errors', 'wpsrd_disable_linked_in_cached' ); remove_action( 'pre_transient_wpsrd_settings_errors', 'wpsrd_disable_linked_in_cached' ); remove_action( 'delete_transient_wpsrd_settings_errors', 'wpsrd_disable_linked_in_cached' ); Let me know if it works 😉 Best, Thanks, the hooks fixed the issue. 🙂 Do you plan to integrate this fix when the plugin Redis Object Cache is activated? Glad to hear that. No I think I will only apply the above filters if W3 Total Cache is activated (don’t why I didn’t do that at first…) Glad to hear that. No I think I will only apply the above filters if W3 Total Cache is activated (don’t know why I didn’t do that at first…) If this is broken by default with any object caching solution, doesn’t it make sense to fix this? I said “apply”, not “remove” filters 😉 Ah maybe I misunderstood. I was referring to: Do you plan to integrate this fix when the plugin Redis Object Cache is activated? The plugin is used by 60,000 sites. The fix is to apply the above filters only when W3 Total Cache is activated (if still needed). That mean there will no need to remove them with other caching solutions. Update done. I’ve completely remove the W3 Total Cache filters previously added since it does not since to be required anymore. You can remove the the above filters. Best, I confirm the issue is now fixed with the 1.5.1 update. Thanks for the support! 🙂

Comments

12 shown
Brice Capobianco 2020-09-16T06:39:00+00:00

Hi, I can’t see any reason why this issue happens. The plugin is mostly using core functions and do not interact on the caching side. Can you tell me if you’re using the classic editor or no ? If you have any javascript error in the console ? If there is XHR issues ? Cheers, Brice

Greys 2020-09-16T06:53:00+00:00

Hi @brikou , Totally agree, when I was troubleshooting this issue, I did not think your plugin could be the cause. You can reproduce the exact same issue with a fresh install with WooCommerce and Redis Object Cache installed and activated. Nothing more. The theme used doesn’t matter. On the other hand, I do not have any javascript or PHP errors. Cheers, John Greys This reply was modified 5 years, 8 months ago by Greys . This reply was modified 5 years, 8 months ago by Greys .

Brice Capobianco 2020-09-16T07:18:00+00:00

Hmmm… I thinks I was wrong ! I totally forgot that I did a fix for W3 Total Cache a few years ago because of object caching issues… Fortunatly you can disable the related filters with the following hooks. remove_action( 'set_transient_wpsrd_settings_errors', 'wpsrd_enable_linked_in_cached' ); remove_action( 'transient_wpsrd_settings_errors', 'wpsrd_enable_linked_in_cached' ); remove_action( 'deleted_transient_wpsrd_settings_errors', 'wpsrd_enable_linked_in_cached' ); remove_action( 'pre_set_transient_wpsrd_settings_errors', 'wpsrd_disable_linked_in_cached' ); remove_action( 'pre_transient_wpsrd_settings_errors', 'wpsrd_disable_linked_in_cached' ); remove_action( 'delete_transient_wpsrd_settings_errors', 'wpsrd_disable_linked_in_cached' ); Let me know if it works 😉 Best,

Greys 2020-09-16T07:32:00+00:00

Thanks, the hooks fixed the issue. 🙂 Do you plan to integrate this fix when the plugin Redis Object Cache is activated?

Brice Capobianco 2020-09-16T07:37:00+00:00

Glad to hear that. No I think I will only apply the above filters if W3 Total Cache is activated (don’t why I didn’t do that at first…)

Brice Capobianco 2020-09-16T07:38:00+00:00

Glad to hear that. No I think I will only apply the above filters if W3 Total Cache is activated (don’t know why I didn’t do that at first…)

Till Krüss 2020-09-16T18:04:00+00:00

If this is broken by default with any object caching solution, doesn’t it make sense to fix this?

Brice Capobianco 2020-09-16T18:08:00+00:00

I said “apply”, not “remove” filters 😉

Till Krüss 2020-09-16T18:09:00+00:00

Ah maybe I misunderstood. I was referring to: Do you plan to integrate this fix when the plugin Redis Object Cache is activated? The plugin is used by 60,000 sites.

Brice Capobianco 2020-09-16T18:17:00+00:00

The fix is to apply the above filters only when W3 Total Cache is activated (if still needed). That mean there will no need to remove them with other caching solutions.

Brice Capobianco 2020-09-16T19:12:00+00:00

Update done. I’ve completely remove the W3 Total Cache filters previously added since it does not since to be required anymore. You can remove the the above filters. Best,

Greys 2020-09-16T20:38:00+00:00

I confirm the issue is now fixed with the 1.5.1 update. Thanks for the support! 🙂