WPIntell

Source evidence

Inline CSS is being overridden

Merge + Minify + Refresh · support · 2023-10-13T12:09:00+00:00

mixedsentiment
mediumseverity
0.85relevance
12replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

6 / 29 rows with source links

20.7% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

23 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
Oliver Campion resolved
We have had to disable this plugin on at least one website because it has started interfering with the theme’s (Twenty Twenty) inline CSS by caching it and adding it back in in a different order causing the Customizer changes to be overridden by style.css. This is the CSS that the theme creates … <style id='twentytwenty-style-inline-css'> .color-accent, .color-accent-hover:hover, .color-accent-hover:focus, :root .has-accent-color, .has-drop-cap:not(:focus):first-letter, .wp-block-button.is-style-outline, a { color: #1f7cb7; } <style> … to override the items in style.css namely … a { color: #cd2653; text-decoration: underline; } Please advise. The page I need help with: [ log in to see the link] Interesting. What happens if you turn off css merging? We have ticked “Don’t Merge CSS” and the issue persists. If you visit https://webtec.uk you will see that the links are red and they should be blue. Oliver Hi Oliver, I’ve just pushed out a new version that should solve this. Can you please give it a go? Sorry, links are still showing as red instead of blue. Have tested with and without “Don’t Merge CSS” and have used “Purge All”. Please advise. Oh ok. I’ve been trying to replicate your issue and I can’t. What plugins do you have enabled? How are you setting the colour of the anchor links? OK, this is super easy to replicate 🙂 Fire up a clean install of WordPress v6.3.2 and activate Twenty Twenty theme. Go to “Customizer – Colors – Primary Color” and select whatever colour you want. View the site and notice the colour of links. Install and activate your plugin. You will now see that the colour has reverted to the default red. No other plugins need to be active to replicate the issue. I must be missing something. I don’t have a colours option. When I go to the customiser there is a “colours & dark mode” setting but it only has a background colour. Any idea? Please install Twbty Twenty. You have Twenty Twenty-One. Ahh ha. Thanks. I was sure you were using Twenty Twenty-One. I’ve uploaded a new version that will now fix this issue. Thanks for your patience. OK cool, that’s fixed it … but what’s going on here? Are you making individual rules for themes etc? Because surely you’re not going to ever be able to cover all themes? Or was there an actual bug here with the general ordering of inline CSS and enqueued CSS files? Thanks. haha no. That would be crazy. It was a bug with MMR. It wasn’t respecting inline styles correctly. Infact, MMR hasn’t respected inline styles correctly since it was released. Thanks for reporting this. It should make it much more reliable. Oh wow. Ha! OK, that’s fantastic news then! And actually answers several other issues I’ve had over the years LOL Thank you for fixing this so quickly.

Comments

12 shown
launchinteractive 2023-10-14T04:58:00+00:00

Interesting. What happens if you turn off css merging?

Oliver Campion 2023-10-14T15:13:00+00:00

We have ticked “Don’t Merge CSS” and the issue persists. If you visit https://webtec.uk you will see that the links are red and they should be blue. Oliver

launchinteractive 2023-10-16T03:21:00+00:00

Hi Oliver, I’ve just pushed out a new version that should solve this. Can you please give it a go?

Oliver Campion 2023-10-16T10:55:00+00:00

Sorry, links are still showing as red instead of blue. Have tested with and without “Don’t Merge CSS” and have used “Purge All”. Please advise.

launchinteractive 2023-10-17T02:31:00+00:00

Oh ok. I’ve been trying to replicate your issue and I can’t. What plugins do you have enabled? How are you setting the colour of the anchor links?

Oliver Campion 2023-10-17T13:19:00+00:00

OK, this is super easy to replicate 🙂 Fire up a clean install of WordPress v6.3.2 and activate Twenty Twenty theme. Go to “Customizer – Colors – Primary Color” and select whatever colour you want. View the site and notice the colour of links. Install and activate your plugin. You will now see that the colour has reverted to the default red. No other plugins need to be active to replicate the issue.

launchinteractive 2023-10-17T19:50:00+00:00

I must be missing something. I don’t have a colours option. When I go to the customiser there is a “colours & dark mode” setting but it only has a background colour. Any idea?

Oliver Campion 2023-10-17T20:21:00+00:00

Please install Twbty Twenty. You have Twenty Twenty-One.

launchinteractive 2023-10-18T01:21:00+00:00

Ahh ha. Thanks. I was sure you were using Twenty Twenty-One. I’ve uploaded a new version that will now fix this issue. Thanks for your patience.

Oliver Campion 2023-10-18T07:12:00+00:00

OK cool, that’s fixed it … but what’s going on here? Are you making individual rules for themes etc? Because surely you’re not going to ever be able to cover all themes? Or was there an actual bug here with the general ordering of inline CSS and enqueued CSS files? Thanks.

launchinteractive 2023-10-18T09:32:00+00:00

haha no. That would be crazy. It was a bug with MMR. It wasn’t respecting inline styles correctly. Infact, MMR hasn’t respected inline styles correctly since it was released. Thanks for reporting this. It should make it much more reliable.

Oliver Campion 2023-10-18T09:37:00+00:00

Oh wow. Ha! OK, that’s fantastic news then! And actually answers several other issues I’ve had over the years LOL Thank you for fixing this so quickly.