highlighting found search terms no longer working

this used to work… The page I need help with: [ log in to see the link] i enabled seamless integration & now highlighting is working…after figuring out u switched from <span> to <mark> but it is still not working using your enhanced template I just found a bug on the highlighting of the title which resulted because of me trying to fix another bug with the title. I need to work through this to see how I can get that fixed. GitHub issue filed: https://github.com/WebberZone/better-search/issues/115 I think I’ve been able to fix both the issue of highlighting in the search results page where the terms after the first title didn’t work and also when there were quotes. This is in seamless mode. I’m still working through the bug with seamless mode off. Are you able to try this beta? https://github.com/WebberZone/better-search/releases/tag/4.0.3-beta1 This reply was modified 1 year, 5 months ago by Ajay . yup, trying it right now…sorry, samesame-( I just fixed the seamless mode as well as some other highlighting issues. I rewrote the beta version to the same file. https://github.com/WebberZone/better-search/releases/tag/4.0.3-beta1 On your other issue on double-quotes, I’m not sure what that problem is as I can’t replicate it. You might need to check the queries generated. See here: https://webberzone.com/support/knowledgebase/debugging-with-query-monitor/ If that also doesn’t work, can you please create a support ticket referring to this forum post: https://webberzone.com/request-support/ hotDAWG! hiliting works again with seamless off, thanx…i do like the features your better-search-template.php adds-) i’ll see what query monitor shows & get back 2 u… I’ll push through 4.0.3 today that fixes this as I’m sure if effects others. On your quotes issue, as I can’t replicate it on my various installs. I’ve tried with and without boolean mode on. have u tried the search on my website? i have a category “bad neighbors” that has 11 posts, but none of them are found…i did notice that in 1 match, “bad neighbors” was in a related post @ the bottom…r u searching on the entire page as shown in front end? i am including comments. and why is nothing found when Enable seamless integration is set? i will look at query monitor… and 1 other thing: a matched comment is labeled with a paperclip but the title is prefixed with gvl: gvlRefer a neighbor which is the file name of the image included in the comment ah, under banned words: “With seamless mode on, this will give a Nothing found message.” if stop query is enabled, but it’s not on my site. perhaps this is a factor? gotta luv the combinatorial explosion, eh?-} Can you make note of the settings’ changes that you have made and then reset the settings with the button at the bottom. Then start reapplying. What do you have in the banned words box? Have you had a chance to check the query in Query Monitor? i have cleared banned words to avoid any problems there…here’s the q.m.: SELECT MAX(( MATCH (wp_posts.post_title) AGAINST (‘\”bad neighbors\”‘ ) * 10) + ( MATCH (wp_posts.post_content) AGAINST (‘\”bad neighbors\”‘ ) * 1)) as topscore FROM wp_posts WHERE post_date <= ‘2024-12-09 18:42:57’ AND ( post_status = ‘publish’ OR post_status = ‘inherit’ ) AND post_password = ” AND post_type IN (‘post’, ‘page’, ‘attachment’, ‘mec-events’) here’s the q.m. for “bad neighbors” with seamless integration enabled, returning no results: SELECT SQL_CALC_FOUND_ROWS DISTINCT wp_posts.*,wp_posts.ID as ID, ( MATCH (wp_posts.post_title) AGAINST (‘\”bad neighbors\”‘ ) * 10) + ( MATCH (wp_posts.post_content) AGAINST (‘\”bad neighbors\”‘ ) * 1) as score FROM wp_posts LEFT JOIN wp_comments AS bsq_comments ON (wp_posts.ID = bsq_comments.comment_post_ID) WHERE 1=1 AND ( wp_posts.post_date <= ‘2024-12-10 09:59:30’ ) AND (( MATCH (wp_posts.post_title) AGAINST (‘\”bad neighbors\”‘ ) * 10) + ( MATCH (wp_posts.post_content) AGAINST (‘\”bad neighbors\”‘ ) * 1) OR ( ((wp_posts.post_excerpt LIKE ‘%\”bad neighbors\”%’) OR (bsq_comments.comment_content LIKE ‘%\”bad neighbors\”%’)) ) ) AND (wp_posts.post_password = ”) AND wp_posts.post_type IN (‘attachment’, ‘mec-events’, ‘page’, ‘post’) AND ((wp_posts.post_status = ‘publish’ OR wp_posts.post_status = ‘inherit’)) ORDER BY score DESC LIMIT 0, 10 and here’s query with seamless disabled, returning 104 matches of the individual words, not the quoted phrase: SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND (((wp_posts.post_title LIKE '%bad neighbors%') OR (wp_posts.post_excerpt LIKE '%bad neighbors%') OR (wp_posts.post_content LIKE '%bad neighbors%'))) AND ((wp_posts.post_type = 'attachment' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private')) OR (wp_posts.post_type = 'mec-events' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private')) OR (wp_posts.post_type = 'page' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private')) OR (wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private'))) ORDER BY wp_posts.post_title LIKE '%bad neighbors%' DESC , wp_posts.post_date DESC LIMIT 0, 5 why do the integration types use different sql? trying seamless enabled with single quotes ‘bad neighbors’ now finds 105 matches, but words no longer hilited: SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND (((wp_posts.post_title LIKE ‘%bad%’) OR (wp_posts.post_excerpt LIKE ‘%bad%’) OR (wp_posts.post_content LIKE ‘%bad%’)) AND ((wp_posts.post_title LIKE ‘%neighbors%’) OR (wp_posts.post_excerpt LIKE ‘%neighbors%’) OR (wp_posts.post_content LIKE ‘%neighbors%’))) AND ((wp_posts.post_type = ‘attachment’ AND (wp_posts.post_status = ‘publish’ OR wp_posts.post_status = ‘private’)) OR (wp_posts.post_type = ‘mec-events’ AND (wp_posts.post_status = ‘publish’ OR wp_posts.post_status = ‘private’)) OR (wp_posts.post_type = ‘page’ AND (wp_posts.post_status = ‘publish’ OR wp_posts.post_status = ‘private’)) OR (wp_posts.post_type = ‘post’ AND (wp_posts.post_status = ‘publish’ OR wp_posts.post_status = ‘private’))) ORDER BY ( CASE WHEN wp_posts.post_title LIKE ‘%\’bad neighbors\’%’ THEN 1 WHEN wp_posts.post_title LIKE ‘%bad%’ AND wp_posts.post_title LIKE ‘%neighbors%’ THEN 2 WHEN wp_posts.post_title LIKE ‘%bad%’ OR wp_posts.post_title LIKE ‘%neighbors%’ THEN 3 WHEN wp_posts.post_excerpt LIKE ‘%\’bad neighbors\’%’ THEN 4 WHEN wp_posts.post_content LIKE ‘%\’bad neighbors\’%’ THEN 5 ELSE 6 END ), wp_posts.post_date DESC LIMIT 0, 5 @airdrummer Thanks for the checking. The single quote doesn’t do anything. Needs to be double I believe. On the queries, the double quotes forces a phrase and anything not in the phrase gets excluded. With seamless disabled, you’ll see two sets of queries – one is the “main query”, but that doesn’t apply. The second is the query you can get by filtering the Better Search Component and WP_Query->get_posts(). This one should be a match query. I need to check on the single quote highlighting, I might have to work on the code. On the queries, the double quotes forces a phrase and anything not in the phrase gets excluded. not for me, it simply matches anything with either word…for this query https://cardinalglen.org/?s=%22bad+neighbors%22 the 1st match https://cardinalglen.org/80-survival-isnt-bad/ contains only bad…except for a related post https://cardinalglen.org/our-new-tree-is-gone/ which does contain “bad neighbors” as a category and another matching post https://cardinalglen.org/304-cgc-smelled-gas/ contains neither word… under inclusion options, i have enabled Search Excerpt & Search Comments i also enabled Highlight followed links, but i’m realyy not sure what u mean by If enabled, the plugin will highlight the search terms on posts/pages when visits them from the search results page. i will check on the 2nd query… This reply was modified 1 year, 5 months ago by airdrummer . ok here it is: SELECT SQL_CALC_FOUND_ROWS DISTINCT wp_posts.*,wp_posts.ID as ID, ( MATCH (wp_posts.post_title) AGAINST ('"bad neighbors"' ) * 10) + ( MATCH (wp_posts.post_content) AGAINST ('"bad neighbors"' ) * 1) as score FROM wp_posts LEFT JOIN wp_comments AS bsq_comments ON (wp_posts.ID = bsq_comments.comment_post_ID) WHERE 1=1 AND ( wp_posts.post_date <= '2024-12-10 20:31:30' ) AND (( MATCH (wp_posts.post_title) AGAINST ('"bad neighbors"' ) * 10) + ( MATCH (wp_posts.post_content) AGAINST ('"bad neighbors"' ) * 1) OR ( ((wp_posts.post_excerpt LIKE '%"bad%') OR (bsq_comments.comment_content LIKE '%"bad%')) AND ((wp_posts.post_excerpt LIKE '%neighbors"%') OR (bsq_comments.comment_content LIKE '%neighbors"%')) ) ) AND (wp_posts.post_password = '') AND wp_posts.post_type IN ('attachment', 'mec-events', 'page', 'post') AND ((wp_posts.post_status = 'publish' OR wp_posts.post_status = 'inherit')) ORDER BY score DESC LIMIT 0, 10 my sql is a bit rusty, but running it in phpmyadmin returns no hits…also notice your LIKE phrases include the quotes in front of bad & after neighbors, indicating that the quotes are not actually recognized as delimiting a phrase This reply was modified 1 year, 5 months ago by airdrummer . @airdrummer I think there is still a bug when handling quotes that looks fine when running through Query Monitor but it wasn’t for the actual query run in the database. I need to do a bit more digging and testing to see how I can get an optimum result. As per MySQL docs, the double quotes without boolean finds the search term literally, but that doesn’t seem to be the case when I’m running it. ok thanx for looking into this happy holidaze-) Thanks for the patience. Are you in a position to try this? I am hoping this fixes it because I’m pretty much stuck on a solution for the quotes if this doesn’t work! https://github.com/WebberZone/better-search/releases/tag/4.0.4-beta1 thanx i’ll give it a try…right now debugging an email notification problem;-\ woot! it works! thanx…although the category “bad neighbors” isn’t hilited, and the term neighbors is hilited even when not in the full phrase, and the Sort by: Date and Results per-page: 10 | All links are url-escaped & non-functional: https://cardinalglen.org/?s%22bad%20neighbor%22&post_types&bydate=1 but i’ll take progress on the most important issue-) i know how frustrating debugging is, having worked in s/w dev over 25yrs, and i’m happy to provide the feedback…how i try to keep busy in retirement;-) happy holidaze!-) now for my email problem I can see it’s working now. I noticed your post on the term “bad neighbors” not being highlighted. Is that what you meant? yes, the category “bad neighbors” isn’t hilited..not major issue what is a show-stopper is the Sort by: Date & pagination links missing the = sign after the ?s, so broken: https://cardinalglen.org/?s%22bad%20neighbor%22&post_types&bydate=1 note the missing =^^^^^^after ?s This reply was modified 1 year, 5 months ago by airdrummer . i found out what the problem is: in better-search/includes/general-template.php when $rel_or_date_link_args[‘s’] starts with a quote, add_query_arg skips adding the ‘=’ breaking the url-\ so izzat a bug or a feature?-\ https://developer.wordpress.org/reference/functions/add_query_arg/?unapproved=7245&moderation-hash=8184e2ed20311fe15792090c01abc484#comment-7245 Wow. That’s a weird bug. Let me run some checks (likely later today) to see what I can do. ftfy;-) https://github.com/WebberZone/better-search/pull/116 Thanks for this. I’ve merged the PR! I’m planning to get a version out with these fixes. happy to help:-) btw, Plugin Name: Better Search Pro? This reply was modified 1 year, 5 months ago by airdrummer . Sorry, I just saw this. It’s a bit painful managing my pro repo with the free one, and that’s where the better-search.php file got overwritten when I didn’t pay attention. Here’s the link to Better Search Pro: https://webberzone.com/plugins/better-search/pro/