Conversation
supportHi all, The fonts are being loaded through http instead of https, creating errors on https environments. Is there a possibility this is fixed in future releases? You really only need to add the ‘s’. https://wordpress.org/plugins/tk-google-fonts/
Hi @sjorshijgenaar , I have uploaded a new version with https support. Cheers, Sven
Hi Sven, Version 1.3.2 still contains a link to non-https URL. In file tk-google-fonts/includes/helper-functions.php line 27, I replaced ‘ http://fonts.googleapis.com’ ; to ‘//fonts.googleapis.com’. That worked for me. The whole file can be simplified because of (nearly) duplicated code: wp_register_style/wp_enqueue_style function calls in ‘selected_fonts’ loops. But that’s my opinion.
Hi @akamp , this is definitely true and a great improvement. I will make sure it gets changed for the upcoming version. If you are willing to create a pull request of your changes would be a great help and speed up the process. https://github.com/Themekraft/tk-google-fonts Contributions are Welcome! 😉 Cheers, Sven
Hi @sjorshijgenaar , I have uploaded a new version with https support. Cheers, Sven
Hi Sven, Version 1.3.2 still contains a link to non-https URL. In file tk-google-fonts/includes/helper-functions.php line 27, I replaced ‘ http://fonts.googleapis.com’ ; to ‘//fonts.googleapis.com’. That worked for me. The whole file can be simplified because of (nearly) duplicated code: wp_register_style/wp_enqueue_style function calls in ‘selected_fonts’ loops. But that’s my opinion.
Hi @akamp , this is definitely true and a great improvement. I will make sure it gets changed for the upcoming version. If you are willing to create a pull request of your changes would be a great help and speed up the process. https://github.com/Themekraft/tk-google-fonts Contributions are Welcome! 😉 Cheers, Sven