WPIntell

Source evidence

Fixing Validation Errors

iCal Feeds 路 support 路 2017-09-21T04:16:00+00:00

mixedsentiment
mediumseverity
0.84relevance
3replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

4 / 33 rows with source links

12.1% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

29 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
contemplate resolved
While testing importing the iCal into non-Apple calendars I consistently get errors. When I run the iCal feed through a validator it throws errors like this: Error at line 11:Cannot set timezone for UTC It points to DSTAMP and the way the plugin uses timezones. Then I found a bunch of articles pointing to the need for only using the Z format. So I鈥檓 suggesting these changes: change this $start_time = date( 'Ymd\THis', get_post_time( 'U', false, $post->ID ) ); $end_time = date( 'Ymd\THis', get_post_time( 'U', false, $post->ID ) + ($options['icalfeeds_minutes'] * 60)); to this: $start_time = date( 'Ymd\THis', get_post_time( 'U', true, $post->ID ) ); $end_time = date( 'Ymd\THis', get_post_time( 'U', true, $post->ID ) + ($options['icalfeeds_minutes'] * 60)); And then change this: $modified_time = date( 'Ymd\THis', get_post_modified_time( 'U', false, $post->ID ) ); to this: $modified_time = date( 'Ymd\THis', get_post_modified_time( 'U', true, $post->ID ) ); and finally change this: if ($timezone === 'UTC') { $start_time = ":$start_time" . 'Z'; $end_time = ":$end_time" . 'Z'; $modified_time = ":$modified_time" . 'Z'; } else { $start_time = ";TZID=$timezone:$start_time"; $end_time = ";TZID=$timezone:$end_time"; $modified_time = ";TZID=$timezone:$modified_time"; } to this: $start_time = ":$start_time" . 'Z'; $end_time = ":$end_time" . 'Z'; $modified_time = ":$modified_time" . 'Z'; Hope that helps. Added in 1.4.2, thanks 馃檪 Did 1.4.2 ever get released?!? Weird, the commit never went to WordPress. I pushed a dummy commit and it鈥檚 OK now. Sorry!

Comments

3 shown
maximevalette 2017-09-23T18:34:00+00:00

Added in 1.4.2, thanks 馃檪

contemplate 2017-10-21T16:25:00+00:00

Did 1.4.2 ever get released?!?

maximevalette 2017-10-22T09:15:00+00:00

Weird, the commit never went to WordPress. I pushed a dummy commit and it鈥檚 OK now. Sorry!