Conversation
supportI’ve installed this plugin on 13 sites, and only one throws an error in the logs. The error is marked as “fatal,” but the site’s front and backend are fine. I’ve disabled the plugin on the site for now (even though everything seemed to be fine). Here is a copy of the log data (redacted URL): 2023/08/30 16:32:34 [error] 115596#115596: *657299 FastCGI sent in stderr: “PHP message: PHP Fatal error: Uncaught TypeError: Ginger_MO::translate(): Argument #1 ($text) must be of type string, null given, called in /www/examplecom_444/public/wp-content/plugins/performant-translations/lib/class-performant-translations-compat-provider.php on line 125 and defined in /www/examplecom_444/public/wp-content/plugins/performant-translations/lib/class-ginger-mo.php:219 Stack trace: #0 /www/examplecom_444/public/wp-content/plugins/performant-translations/lib/class-performant-translations-compat-provider.php(125): Ginger_MO->translate(NULL, ”, ‘default’) #1 /www/examplecom_444/public/wp-includes/l10n.php(186): Performant_Translations_Compat_Provider->translate(NULL) #2 /www/examplecom_444/public/wp-includes/l10n.php(297): translate(NULL, ‘default’) #3 /www/examplecom_444/public/wp-content/plugins/woocommerce-tax-display-by-country/src/lib/classes/settings/settings.php(156): __(NULL) #4 /www/examplecom_444/public/wp-content/plugins/woocommerce-tax-display-by-country/s” while reading response header from upstream, client: 92.247.181.31, server: http://www.example.com , request: “GET /news/feed/ HTTP/2.0”, upstream: “fastcgi://unix:/var/run/php8.1-fpm-examplecom.sock:”, host: “www.example.com:29543”, referrer: “ https://www.example.com/” ; I do have this plugin installed on another WooCommerce site and there are no issues at all there. Thanks in advance, Simon
Interesting! This „woocommerce-tax-display-by-country“ plugin is definitely doing something wrong, I‘ll have to check it out. But we should be able to work around it. Expect a new 1.0.2 release this week. This reply was modified 2 years, 9 months ago by Pascal Birchler .
@swissspidy Would you like me to speak to the developer? Would you like me to send you a copy of the plugin for you to look at? (If so, let me know the best way to do that). Thanks in advance!
@harpo1984 Yes, sending a copy would be helpful. I just pinged you on Slack, you could share it there.
Same error triggered from broken-link-checker. Passed null to esc_attr_e Which does not have strict type checking. broken-link-checker/app/admin-modals/local/class-view.php(60): esc_attr_e() Passed variable is self::$unique_id might by null. I think that should be an empty string, but who should I blame on this? This reply was modified 2 years, 9 months ago by brbrbr . This reply was modified 2 years, 9 months ago by brbrbr .
@brbrbr Thanks for sharing! I can’t reproduce this with broken-link-checker, but I do have a new release coming that should address this, so stay tuned.
I just released 1.0.2 which fixes this issue, marking this as resolved now. Thanks again for your report & help with fixing this!
Interesting! This „woocommerce-tax-display-by-country“ plugin is definitely doing something wrong, I‘ll have to check it out. But we should be able to work around it. Expect a new 1.0.2 release this week. This reply was modified 2 years, 9 months ago by Pascal Birchler .
@swissspidy Would you like me to speak to the developer? Would you like me to send you a copy of the plugin for you to look at? (If so, let me know the best way to do that). Thanks in advance!
@harpo1984 Yes, sending a copy would be helpful. I just pinged you on Slack, you could share it there.
Same error triggered from broken-link-checker. Passed null to esc_attr_e Which does not have strict type checking. broken-link-checker/app/admin-modals/local/class-view.php(60): esc_attr_e() Passed variable is self::$unique_id might by null. I think that should be an empty string, but who should I blame on this? This reply was modified 2 years, 9 months ago by brbrbr . This reply was modified 2 years, 9 months ago by brbrbr .
@brbrbr Thanks for sharing! I can’t reproduce this with broken-link-checker, but I do have a new release coming that should address this, so stay tuned.
I just released 1.0.2 which fixes this issue, marking this as resolved now. Thanks again for your report & help with fixing this!