WPIntell

Source evidence

Does not Work with TRL

wp-admin classic · support · 2013-12-20T17:20:00+00:00

complaintsentiment
mediumseverity
0.92relevance
3replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

5 / 31 rows with source links

16.1% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

26 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
yoramzara unresolved
I have WordPress in Hebrew. When activating the plugin all the directions get messed up http://wordpress.org/plugins/wp-admin-classic/ @yoramzara Noticed, no quick solution is available atm. Any suggestions welcome! Thanks FWIW, it looks like the way WP deals with RTL stylesheets changed completely in 3.8: https://core.trac.wordpress.org/ticket/24977 Prior to 3.8, AIUI, WP loaded the LRT stylesheets and then also loaded the RTL ones, which overrode (parts of) the LTR ones (and some LTR stylesheets also had RTL-specific blocks using an rtl class), so to get a complete theme in RTL, you’d need both LTR and RTL files. In 3.8, WP includes auto-generated RTL stylesheets that are complete copies of the LTR ones with flipped CSS in appropriate places, and for RTL sites now only loads the RTL files, so 3.8 loading 3.7 RTL CSS files looks like it’s going to bad. Assuming that’s what’s actually happening (I haven’t checked the code, and not sure I could tell if I did), if seems like there are two options: 1) Convert all the admin CSS to 3.8-style, where RTL files are complete, standalone sets of styles (seems like a world of pain) 2) This old post about WP’s initial RTL support (ca. WP 2.0.x) notes there’s a $text_direction variable RTL locales set. If that’s still the case in 3.8, perhaps it’s possible to check that variable and force WP to load LTR+RTL files somehow. Neither seems like a really great option 🙁 @sardisson I suppose its not a big issue to load bunch of css files, after all its for back-end only, and there is not much traffic on it and in most of the cases you don’t really need to reload page that often. I suppose it would be great to have some sort of single file style loader but its not high priority. Regarding the styles I already peaked and attempted to load RTL css but that was so easy as expected. Will look into the diff between LTR and RTL and check if it’s feasible to make stand alone css files for RTL. Including them probably would be pretty simple then.

Comments

3 shown
mch0lic 2014-01-03T20:46:00+00:00

@yoramzara Noticed, no quick solution is available atm. Any suggestions welcome! Thanks

sardisson 2014-01-03T22:34:00+00:00

FWIW, it looks like the way WP deals with RTL stylesheets changed completely in 3.8: https://core.trac.wordpress.org/ticket/24977 Prior to 3.8, AIUI, WP loaded the LRT stylesheets and then also loaded the RTL ones, which overrode (parts of) the LTR ones (and some LTR stylesheets also had RTL-specific blocks using an rtl class), so to get a complete theme in RTL, you’d need both LTR and RTL files. In 3.8, WP includes auto-generated RTL stylesheets that are complete copies of the LTR ones with flipped CSS in appropriate places, and for RTL sites now only loads the RTL files, so 3.8 loading 3.7 RTL CSS files looks like it’s going to bad. Assuming that’s what’s actually happening (I haven’t checked the code, and not sure I could tell if I did), if seems like there are two options: 1) Convert all the admin CSS to 3.8-style, where RTL files are complete, standalone sets of styles (seems like a world of pain) 2) This old post about WP’s initial RTL support (ca. WP 2.0.x) notes there’s a $text_direction variable RTL locales set. If that’s still the case in 3.8, perhaps it’s possible to check that variable and force WP to load LTR+RTL files somehow. Neither seems like a really great option 🙁

mch0lic 2014-01-04T07:24:00+00:00

@sardisson I suppose its not a big issue to load bunch of css files, after all its for back-end only, and there is not much traffic on it and in most of the cases you don’t really need to reload page that often. I suppose it would be great to have some sort of single file style loader but its not high priority. Regarding the styles I already peaked and attempted to load RTL css but that was so easy as expected. Will look into the diff between LTR and RTL and check if it’s feasible to make stand alone css files for RTL. Including them probably would be pretty simple then.