WPIntell

Source evidence

Chan broke his own code

WP-ShowHide · review · 2019-11-11T19:23:00+00:00

complaintsentiment
highseverity
1.0relevance
3replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

5 / 33 rows with source links

15.2% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

28 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

review · 2 stars
ilinna unresolved
I’ve been using this Show/Hide plugin for a few years now. It used to be that the code was this [showhide type=”post” more_text=”Show the spoiler…” less_text=“Hide the spoiler…”] Text you want to hide [/showhide] And I could insert whatever text I wanted within the quote marks. Then Chan broke it. Now it says “Show Press Release” regardless of the text I put in the quote marks. I told Chan about this and the fact that the plugin completely failed the last time I tried using it. Now he’s fixed it so it does still show and hide but it keeps the “Show Press Release” text regardless of the text I put in the quote marks. Chan’s response: change the CSS code. Really?! So unhelpful! It’s going to take some research to figure out how to find his code segment in my CSS code. Why would you take an elegant piece of coding and break it? This topic was modified 6 years, 6 months ago by ilinna . It might be your quotes that are incorrect or you are typing it in the visual editor. Note that this is not compatible with Gutenberg. The plugin code has not bee touch in two years, https://github.com/lesterchan/wp-showhide/blob/master/wp-showhide.php . The last update to it was 15 Jul 2017. So it might be a user error? This reply was modified 6 years, 6 months ago by Lester Chan . Oh dear. According to this screenshot , your code was last updated 3 weeks ago. Does that mean it’s been hacked? That is only the version bump. The main code was not touched. This is the only change https://github.com/lesterchan/wp-showhide/commit/4e45d0e854b1064c187756a3a953b0f54a2f0f03 , as you can see I only bump the version from 5.0 to 5.3. This reply was modified 6 years, 6 months ago by Lester Chan .

Comments

3 shown
Lester Chan 2019-11-12T03:11:00+00:00

It might be your quotes that are incorrect or you are typing it in the visual editor. Note that this is not compatible with Gutenberg. The plugin code has not bee touch in two years, https://github.com/lesterchan/wp-showhide/blob/master/wp-showhide.php . The last update to it was 15 Jul 2017. So it might be a user error? This reply was modified 6 years, 6 months ago by Lester Chan .

ilinna 2019-11-12T04:37:00+00:00

Oh dear. According to this screenshot , your code was last updated 3 weeks ago. Does that mean it’s been hacked?

Lester Chan 2019-11-12T09:32:00+00:00

That is only the version bump. The main code was not touched. This is the only change https://github.com/lesterchan/wp-showhide/commit/4e45d0e854b1064c187756a3a953b0f54a2f0f03 , as you can see I only bump the version from 5.0 to 5.3. This reply was modified 6 years, 6 months ago by Lester Chan .