Conversation
supportThis is a bizarre issue, I’m really not sure what’s going on. We’re using your plugin, and have found that sometimes attributes get randomly removed when editing a page, even if no edits to the tabs themselves were made. See the diff I linked to for example, at the bottom of that diff (I included the entire diff for context). In this case, it looks like the user removed a slide from the slideshow, and it broke the tabs somehow. Any ideas on what could be causing this? Could it possibly be a conflict with ACF somehow? The page I need help with: [ log in to see the link]
@revxx14 Thanks for bringing this to my attention. The tabs plugin uses the block clientId as a unique identifier, it seems when other blocks outside of the tabs are modified/removed, it can change the clientId of the tabs. I’m currently working on refactoring this plugin, and I will be sure this is fixed in the next update.
Awesome, glad you were able to spot the issue so easily, thanks!
@revxx14 Version 2.0.0 was released which should fix this issue. I would like to warn however if you have any custom CSS applied to the tabs, to test the plugin update on a staging environment before upgrading on production
Aha, thanks much! The way the layout works in this new version is really clever; using grid to keep the buttons next to their content, that also allows a nice fallback to accordions on mobile. I’ve got two issues I’m seeing when you select anything other than “left” for justification, not sure if you’ll be able to help… The content takes on the width of the tabs. I want to be able to control the alignment of the tabs, while keeping the content the full width of the parent container. Is that possible? I’ve tried playing around with the CSS, to no avail. The last tab is including the gap between elements on the right edge, which leads to the tabs not aligning properly; they’ll be slightly off center, or slightly off the right edge. I can live with the second item, but the first one’s really frustrating; the design I was given for this tab system requires the tabs to be centered, with the content full width, so I’m sort of stuck here.
@revxx14 Thanks for bringing this to my attention. The tabs plugin uses the block clientId as a unique identifier, it seems when other blocks outside of the tabs are modified/removed, it can change the clientId of the tabs. I’m currently working on refactoring this plugin, and I will be sure this is fixed in the next update.
Awesome, glad you were able to spot the issue so easily, thanks!
@revxx14 Version 2.0.0 was released which should fix this issue. I would like to warn however if you have any custom CSS applied to the tabs, to test the plugin update on a staging environment before upgrading on production
Aha, thanks much! The way the layout works in this new version is really clever; using grid to keep the buttons next to their content, that also allows a nice fallback to accordions on mobile. I’ve got two issues I’m seeing when you select anything other than “left” for justification, not sure if you’ll be able to help… The content takes on the width of the tabs. I want to be able to control the alignment of the tabs, while keeping the content the full width of the parent container. Is that possible? I’ve tried playing around with the CSS, to no avail. The last tab is including the gap between elements on the right edge, which leads to the tabs not aligning properly; they’ll be slightly off center, or slightly off the right edge. I can live with the second item, but the first one’s really frustrating; the design I was given for this tab system requires the tabs to be centered, with the content full width, so I’m sort of stuck here.