WPIntell

Source evidence

Broken on latest WordPress

WP Display Header · review · 2016-03-28T08:28:00+00:00

complaintsentiment
highseverity
0.9relevance
3replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

6 / 31 rows with source links

19.4% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

25 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

review · 1 stars
GoScoutUK unresolved
This plugin no longer works with the srcset adaption wordpress has adopted Interesting, can you expand on how the plugin breaks when working with srcset? WP Display Header only handles the information which header image to show on a specific page, it doesn’t affect the upload or how an image is displayed so it seems unlikely to me that it would be affected. Thanks, Konstantin Related trac issue ticket for WordPress core: https://core.trac.wordpress.org/ticket/40282 The plugin sets a different header image, but the header image _data_ is not updated – as result, the WordPress built-in srcset helper function is unable to generate the srcset-related attributes. As workaround, this plugin can update the header image _data_, too, together with the header image. This reply was modified 9 years, 1 month ago by strarsis . @strarsis , thanks for the heads up! Sorry for not seeing this earlier, but I pushed an update today that should fix the issue. Thanks, Konstantin

Comments

3 shown
Konstantin Obenland 2016-07-22T15:26:00+00:00

Interesting, can you expand on how the plugin breaks when working with srcset? WP Display Header only handles the information which header image to show on a specific page, it doesn’t affect the upload or how an image is displayed so it seems unlikely to me that it would be affected. Thanks, Konstantin

strarsis 2017-04-07T13:57:00+00:00

Related trac issue ticket for WordPress core: https://core.trac.wordpress.org/ticket/40282 The plugin sets a different header image, but the header image _data_ is not updated – as result, the WordPress built-in srcset helper function is unable to generate the srcset-related attributes. As workaround, this plugin can update the header image _data_, too, together with the header image. This reply was modified 9 years, 1 month ago by strarsis .

Konstantin Obenland 2017-12-20T18:23:00+00:00

@strarsis , thanks for the heads up! Sorry for not seeing this earlier, but I pushed an update today that should fix the issue. Thanks, Konstantin