Conversation
review · 1 starsThis plugin no longer works with the srcset adaption wordpress has adopted
Interesting, can you expand on how the plugin breaks when working with srcset? WP Display Header only handles the information which header image to show on a specific page, it doesn’t affect the upload or how an image is displayed so it seems unlikely to me that it would be affected. Thanks, Konstantin
Related trac issue ticket for WordPress core: https://core.trac.wordpress.org/ticket/40282 The plugin sets a different header image, but the header image _data_ is not updated – as result, the WordPress built-in srcset helper function is unable to generate the srcset-related attributes. As workaround, this plugin can update the header image _data_, too, together with the header image. This reply was modified 9 years, 1 month ago by strarsis .
@strarsis , thanks for the heads up! Sorry for not seeing this earlier, but I pushed an update today that should fix the issue. Thanks, Konstantin
Interesting, can you expand on how the plugin breaks when working with srcset? WP Display Header only handles the information which header image to show on a specific page, it doesn’t affect the upload or how an image is displayed so it seems unlikely to me that it would be affected. Thanks, Konstantin
Related trac issue ticket for WordPress core: https://core.trac.wordpress.org/ticket/40282 The plugin sets a different header image, but the header image _data_ is not updated – as result, the WordPress built-in srcset helper function is unable to generate the srcset-related attributes. As workaround, this plugin can update the header image _data_, too, together with the header image. This reply was modified 9 years, 1 month ago by strarsis .
@strarsis , thanks for the heads up! Sorry for not seeing this earlier, but I pushed an update today that should fix the issue. Thanks, Konstantin