WPIntell

Source evidence

Additional Selectors doesn’t work?

Simplelightbox · support · 2023-06-13T11:00:00+00:00

mixedsentiment
mediumseverity
0.85relevance
6replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

4 / 23 rows with source links

17.4% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

19 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
outdoorsdev1 resolved
Suddenly all of the selectors I had that were allowing simplelightbox to work aren’t. I’ve added gb-block-image,simplelightbox,card in the additional selectors but it stil only works with wp-block-image, can you help? This seems to be the case for things in the sidebar as well as on custom post types @outdoorsdev1 Everything stopped working for me as well. It seems like something went wrong in the latest update/version. I decided to just rollback to “Version 2.14.1” with WP Rollback ( https://wordpress.org/plugins/wp-rollback/ ) Everything worked again right away Thanks! This worked for me, the immediate last version is fine. Additionally as a seperate issue the simple-lightbox.legacy.min.js file is loading instead of the standard js script, even though I don’t have legacy selected in the options. It is the same here – the lightbox stopped working altogether, so I rolled it back to 2.14.1. I investigated and a change was made to line 57 of setup.simplelightbox.js, where a regular expression is analyzing the filename , it was changed from this: return /\.(jpe?g|png|gif|mp4|webp|bmp|pdf)(\?[^/]*)*$/i.test(item.getAttribute("href")); to this: var thumbnails = Array.from(anchors).filter(function (item) { return /\.(php_vars.ar_sl_fileExt)(\?[^/]*)*$/i.test(item.getAttribute("href")); }); Interestingly, when I logged the contents of php_vars.ar_sl_fileExt – it was ‘png|jpg|jpeg|gif|webp’ – so it would seem to work – but doesn’t. When I roll it back to the original hard coded string, it works fine. Not sure a variable is allowed within the regular expression and may need to be rolled back. Thanks for mention. I will take a look @aknieriem Have you gotten a chance to look at this? I won’t be able to upgrade until this is resolved. Much appreciated! Should be fixed in newest version. Please give it a try

Comments

6 shown
olekristoffersen 2023-06-15T09:44:00+00:00

@outdoorsdev1 Everything stopped working for me as well. It seems like something went wrong in the latest update/version. I decided to just rollback to “Version 2.14.1” with WP Rollback ( https://wordpress.org/plugins/wp-rollback/ ) Everything worked again right away

outdoorsdev1 2023-06-15T11:35:00+00:00

Thanks! This worked for me, the immediate last version is fine. Additionally as a seperate issue the simple-lightbox.legacy.min.js file is loading instead of the standard js script, even though I don’t have legacy selected in the options.

Katie Ayres 2023-06-15T14:02:00+00:00

It is the same here – the lightbox stopped working altogether, so I rolled it back to 2.14.1. I investigated and a change was made to line 57 of setup.simplelightbox.js, where a regular expression is analyzing the filename , it was changed from this: return /\.(jpe?g|png|gif|mp4|webp|bmp|pdf)(\?[^/]*)*$/i.test(item.getAttribute("href")); to this: var thumbnails = Array.from(anchors).filter(function (item) { return /\.(php_vars.ar_sl_fileExt)(\?[^/]*)*$/i.test(item.getAttribute("href")); }); Interestingly, when I logged the contents of php_vars.ar_sl_fileExt – it was ‘png|jpg|jpeg|gif|webp’ – so it would seem to work – but doesn’t. When I roll it back to the original hard coded string, it works fine. Not sure a variable is allowed within the regular expression and may need to be rolled back.

aknieriem 2023-06-27T12:11:00+00:00

Thanks for mention. I will take a look

Katie Ayres 2023-07-15T17:16:00+00:00

@aknieriem Have you gotten a chance to look at this? I won’t be able to upgrade until this is resolved. Much appreciated!

aknieriem 2023-08-24T10:49:00+00:00

Should be fixed in newest version. Please give it a try