WPIntell

Source evidence

2 issues with .js file

Page Comments Off Please · support · 2013-03-21T13:36:00+00:00

neutralsentiment
mediumseverity
0.59relevance
8replies
Evidence linked to opportunitycommercial context

Proof Health

Open evidence

Commercial opportunities need traceable source links before they are treated as build-worthy.

5 / 25 rows with source links

20.0% of this page's analysis has direct source links.

0 build-decision rows missing links

0 rows here require auditable proof before promotion.

20 rows with no attached evidence

0 rows have source counts but still need direct links.

Conversation

support
Clifford Paulick resolved
1) does not load securely on HTTPS pages Use http://codex.wordpress.org/Determining_Plugin_and_Content_Directories#Available_Functions Instead of http://codex.wordpress.org/Determining_Plugin_and_Content_Directories#Constants These should not be used directly by plugins or themes 2) loads on all wp-admin pages Shouldn’t it only run on post edit screens, not all wp-admin pages (including wp-login.php)? Not as big of a deal as #1, since it doesn’t load on front-end, but just curious. Thanks for this plugin. http://wordpress.org/extend/plugins/page-comments-off-please/ Thanks Clifford! I’ll be sure to add that to today’s fixes. Might as well do an update release soon, I’ll shoot for this week. Aside from this problem, other methods are also too explicit. I have changed other things to help multi-site users and users with custom db prefixes. I really appreciate feedback like this. Keep it coming! thanks, -joe 🙂 What is the .js file for anyways? Legacy-mode mainly. The original version of this plugin used it to manually disable the check-boxes. I kept this functionality in case the new method fails for older installs. I think the toggle all page comments off alerts box also uses it. I dunno…it’s for the various JS needs of the plugin. 🙂 I don’t have legacy mode turned on: http://screencast.com/t/YVcM5znEC4K I don’t want another js file loading, not even on admin. 😉 Just my feedback, not a deal-breaker. Thanks. Yes. The script is always included right now, obviously 😉 I haven’t released the fix for ya -yet. However I’m on it today. I will still include the javascript but only when legacy mode is on or when you are on an admin page. Should be rocking and rolling as of 2.0.2 – thanks! tyvm 🙂

Comments

8 shown
techism 2013-03-21T17:02:00+00:00

Thanks Clifford! I’ll be sure to add that to today’s fixes. Might as well do an update release soon, I’ll shoot for this week. Aside from this problem, other methods are also too explicit. I have changed other things to help multi-site users and users with custom db prefixes. I really appreciate feedback like this. Keep it coming! thanks, -joe

Clifford Paulick 2013-03-21T17:03:00+00:00

🙂 What is the .js file for anyways?

techism 2013-03-21T17:09:00+00:00

Legacy-mode mainly. The original version of this plugin used it to manually disable the check-boxes. I kept this functionality in case the new method fails for older installs.

techism 2013-03-21T17:10:00+00:00

I think the toggle all page comments off alerts box also uses it. I dunno…it’s for the various JS needs of the plugin. 🙂

Clifford Paulick 2013-03-21T19:11:00+00:00

I don’t have legacy mode turned on: http://screencast.com/t/YVcM5znEC4K I don’t want another js file loading, not even on admin. 😉 Just my feedback, not a deal-breaker. Thanks.

techism 2013-03-22T18:08:00+00:00

Yes. The script is always included right now, obviously 😉 I haven’t released the fix for ya -yet. However I’m on it today. I will still include the javascript but only when legacy mode is on or when you are on an admin page.

techism 2013-11-20T00:49:00+00:00

Should be rocking and rolling as of 2.0.2 – thanks!

Clifford Paulick 2013-11-20T07:04:00+00:00

tyvm 🙂