Conversation
support1) does not load securely on HTTPS pages Use http://codex.wordpress.org/Determining_Plugin_and_Content_Directories#Available_Functions Instead of http://codex.wordpress.org/Determining_Plugin_and_Content_Directories#Constants These should not be used directly by plugins or themes 2) loads on all wp-admin pages Shouldn’t it only run on post edit screens, not all wp-admin pages (including wp-login.php)? Not as big of a deal as #1, since it doesn’t load on front-end, but just curious. Thanks for this plugin. http://wordpress.org/extend/plugins/page-comments-off-please/
Thanks Clifford! I’ll be sure to add that to today’s fixes. Might as well do an update release soon, I’ll shoot for this week. Aside from this problem, other methods are also too explicit. I have changed other things to help multi-site users and users with custom db prefixes. I really appreciate feedback like this. Keep it coming! thanks, -joe
🙂 What is the .js file for anyways?
Legacy-mode mainly. The original version of this plugin used it to manually disable the check-boxes. I kept this functionality in case the new method fails for older installs.
I think the toggle all page comments off alerts box also uses it. I dunno…it’s for the various JS needs of the plugin. 🙂
I don’t have legacy mode turned on: http://screencast.com/t/YVcM5znEC4K I don’t want another js file loading, not even on admin. 😉 Just my feedback, not a deal-breaker. Thanks.
Yes. The script is always included right now, obviously 😉 I haven’t released the fix for ya -yet. However I’m on it today. I will still include the javascript but only when legacy mode is on or when you are on an admin page.
Should be rocking and rolling as of 2.0.2 – thanks!
tyvm 🙂
Thanks Clifford! I’ll be sure to add that to today’s fixes. Might as well do an update release soon, I’ll shoot for this week. Aside from this problem, other methods are also too explicit. I have changed other things to help multi-site users and users with custom db prefixes. I really appreciate feedback like this. Keep it coming! thanks, -joe
🙂 What is the .js file for anyways?
Legacy-mode mainly. The original version of this plugin used it to manually disable the check-boxes. I kept this functionality in case the new method fails for older installs.
I think the toggle all page comments off alerts box also uses it. I dunno…it’s for the various JS needs of the plugin. 🙂
I don’t have legacy mode turned on: http://screencast.com/t/YVcM5znEC4K I don’t want another js file loading, not even on admin. 😉 Just my feedback, not a deal-breaker. Thanks.
Yes. The script is always included right now, obviously 😉 I haven’t released the fix for ya -yet. However I’m on it today. I will still include the javascript but only when legacy mode is on or when you are on an admin page.
Should be rocking and rolling as of 2.0.2 – thanks!
tyvm 🙂